引用
1.每个方法都以方法名下一行的顶格大括号开始。
public DefaultMetricsTimer popTimer(DefaultMetricsTimer timer) { Stack<DefaultMetricsTimer> timerStack = getTimerStack(); while (!timerStack.isEmpty()) { DefaultMetricsTimer temp = timerStack.pop(); if (temp.equals(timer)) { return timer; } else { if (isThrowException()) { throw new MetricsException("Invalid stack timer " + temp); } else { LOGGER.warn("Invalid stack timer " + temp); } } } if (isThrowException()) { throw new MetricsException("Unable to find timer " + timer); } else { LOGGER.warn("Unable to find timer " + timer); } return null; }
引用
2.每个方法不超过50行
3.返回组装对象,用先定义,然后return 定义引用的方式
public CorrelationInfo getCorrelationInfo() { CorrelationInfo correlationInfo = null; Stack<DefaultMetricsTimer> timerStack = getTimerStack(); if (!timerStack.isEmpty()) { DefaultMetricsTimer metricsTimer = getTimerStack().peek(); correlationInfo = metricsTimer.getCorrelationInfo(); } else { if (LOGGER.isTraceEnabled()) { LOGGER.trace("Correlation information is unavailable"); } } return correlationInfo; }